Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported
From: Andy Shevchenko
Date: Wed Jun 22 2022 - 13:05:08 EST
On Wed, Jun 22, 2022 at 05:46:52PM +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx>
>
> In uart_get_rs485_mode() only try to get a termination GPIO if RS485 bus
> termination is supported by the driver.
I'm not sure I got the usefulness of this change.
We request GPIO line as optional, so if one is defined it in the DT/ACPI, then
they probably want to (opportunistically) have it.
The certain driver may or may not utilize this GPIO.
With your change it's possible to have a DTS where GPIO line defined in a
broken way and user won't ever know about it, if they are using platforms
without termination support.
--
With Best Regards,
Andy Shevchenko