Re: [PATCH v3] iio: trigger: warn about non-registered iio trigger getting attempt
From: Dmitry Rokosov
Date: Wed Jun 22 2022 - 13:52:25 EST
Jonathan,
On Sat, Jun 18, 2022 at 02:27:03PM +0100, Jonathan Cameron wrote:
> On Thu, 16 Jun 2022 09:13:00 +0000
> Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote:
>
> > Hello Jonathan,
> >
> > I notice the patchset from
> > https://lore.kernel.org/all/20220524181150.9240-1-ddrokosov@xxxxxxxxxxxxxx/
> > is not merged to stable yet.
> > I think if this WARN() patch is okay for you, maybe it's better to merge
> > it together with the previous one. It will notify developers about this
> > problem as you suggested before, and the previous patchset resolves the issue
> > in the all IIO drivers.
> >
> > What do you think about it?
>
> It would be a stretch to take a defensive measure like this into stable,
> so I'll just queue this up for the next merge window. We might have
> some exciting intermediate times where anyone actually using the togreg
> branch directly will get drivers that will spit out the warning.
> That should only be people active on the list though who will find
> this quickly enough and understand what is gong on.
>
> I'm fine with this and it's been on list long enough for anyone else to comment.
> It'll be in a branch I'm happy to rebase for at few days anyway if there
> are any last minute comments or tags.
>
> Applied to the togreg branch of iio.git and pushed out as testing.
>
> Hopefully I'll get a pull request out for the fixes-togreg branch
> sometime this weekend.
Thanks a lot for such detailed clarification! I'm seeing this warn
patchset in the linux-next already.
--
Thank you,
Dmitry