Re: [PATCH 33/49] mfd: rohm-bd718x7: drop useless mask_invert flag on irqchip

From: Vaittinen, Matti
Date: Thu Jun 23 2022 - 05:09:24 EST


On 6/20/22 23:06, Aidan MacDonald wrote:
> There's no need to set the flag explicitly to false, since that
> is the default value from zero initialization.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx>
> ---
> drivers/mfd/rohm-bd718x7.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index bfd81f78beae..ad6c0971a997 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -70,7 +70,6 @@ static struct regmap_irq_chip bd718xx_irq_chip = {
> .mask_base = BD718XX_REG_MIRQ,
> .ack_base = BD718XX_REG_IRQ,
> .init_ack_masked = true,
> - .mask_invert = false,
> };
>
> static const struct regmap_range pmic_status_range = {

Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

--
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~