Re: [PATCH v4 10/20] arm64: topology: Remove redundant setting of llc_id in CPU topology
From: Catalin Marinas
Date: Thu Jun 23 2022 - 11:55:58 EST
On Tue, Jun 21, 2022 at 08:20:24PM +0100, Sudeep Holla wrote:
> Since the cacheinfo LLC information is used directly in arch_topology,
> there is no need to parse and fetch the LLC ID information only for
> ACPI systems.
>
> Just drop the redundant parsing and setting of llc_id in CPU topology
> from ACPI PPTT.
>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Reviewed-by: Gavin Shan <gshan@xxxxxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> Hi Will/Catalin,
>
> This is part of a series updating topology to get both ACPI and DT view
> aligned. I have not cc-ed you assuming you won't be interested. Let me
> know if you are. The parts affecting arm64 is just this patch removing
> some unnecessary ACPI code that is now moved to core arch_topology.c
>
> Please ack if you are happy with this and OK to take this as part of the
> series.
Yeah, that's fine, keep it with the rest of the series.
--
Catalin