Re: [PATCH v5 05/14] dt-bindings: nvmem: Add fsl,scu-ocotp yaml file

[Krzysztof Kozlowski]

On 16/06/2022 18:42, Viorel Suman wrote:
> From: Abel Vesa <abel.vesa@xxxxxxx>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'ocotp' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> ---
>  .../bindings/nvmem/fsl,scu-ocotp.yaml         | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml
> new file mode 100644
> index 000000000000..071171e55218
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/fsl,scu-ocotp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - OCOTP bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Dong Aisheng <aisheng.dong@xxxxxxx>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +  Detailed bindings are described in bindings/nvmem/nvmem.txt
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8qm-scu-ocotp
> +      - fsl,imx8qxp-scu-ocotp
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +patternProperties:
> +  "^mac@[0-9a-f]*$":

Use consistent quotes, either " or '.

> +    type: object
> +
> +required:
> +  - compatible
> +  - '#address-cells'
> +  - '#size-cells'
> +

missing allOf referencing nvmem. You can skip then address/size cells
and use unevaluatedProperties:false.

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    imx8qx-ocotp {
> +             compatible = "fsl,imx8qxp-scu-ocotp";

Wrong indentation.

> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +
> +             fec_mac0: mac@2c4 {
> +                    reg = <0x2c4 6>;
> +             };
> +    };


Best regards,
Krzysztof