Re: [PATCH v5 07/14] dt-bindings: rtc: Add fsl,scu-rtc yaml file

[Krzysztof Kozlowski]

On 16/06/2022 18:42, Viorel Suman wrote:
> From: Abel Vesa <abel.vesa@xxxxxxx>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'rtc' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> ---
>  .../devicetree/bindings/rtc/fsl,scu-rtc.yaml  | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml b/Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml
> new file mode 100644
> index 000000000000..a2594fdd486f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/fsl,scu-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - RTC bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Dong Aisheng <aisheng.dong@xxxxxxx>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +
> +properties:
> +  compatible:
> +    const: fsl,imx8qxp-sc-rtc
> +
> +required:
> +  - compatible

Missing allOf with ref to rtc.yaml.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rtc {

Wrong indentation.

> +             compatible = "fsl,imx8qxp-sc-rtc";
> +    };


Best regards,
Krzysztof