Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks.

From: Krzysztof Kozlowski
Date: Fri Jun 24 2022 - 11:23:22 EST


On 24/06/2022 11:19, Krishna chaitanya chundru wrote:
> Add missing clocks.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 0b69b12..313b981 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -438,6 +438,8 @@ allOf:
> - const: slave_q2a # Slave Q2A clock
> - const: tbu # PCIe TBU clock
> - const: ddrss_sf_tbu # PCIe SF TBU clock
> + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock
> + - const: aggre1 # Aggre NoC PCIe1 AXI clock

Hi,

This won't work. You need to update other entry. If you test it with
`make dtbs_check` you will see the errors.

Best regards,
Krzysztof