Re: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding style issues

From: Joe Perches
Date: Sat Jun 25 2022 - 05:38:04 EST


On Sat, 2022-06-25 at 18:49 +1000, Gabriel Viso Carrera wrote:
> Fixed a couple of comment aligment & formatting coding style issues.

trivia:

> diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
[]
> @@ -402,11 +403,11 @@ static bool tb_ctl_handle_event(struct tb_ctl *ctl, enum tb_cfg_pkg_type type,
> static void tb_ctl_rx_submit(struct ctl_pkg *pkg)
> {
> tb_ring_rx(pkg->ctl->rx, &pkg->frame); /*
> - * We ignore failures during stop.
> - * All rx packets are referenced
> - * from ctl->rx_packets, so we do
> - * not loose them.
> - */
> + * We ignore failures during stop.
> + * All rx packets are referenced
> + * from ctl->rx_packets, so we do
> + * not loose them.
> + */

I'd indent this only 1 level and put it before the call
(and fix the loose/lose typo)

{
/* We ignore failures during stop.
* All rx packets are referenced from ctl->rx_packets,
* so we do not lose them.
*/
tb_ring_rx(pkg->ctl->rx, &pkg->frame);
}