Re: [PATCH v12 2/4] trace/objtrace: Get the value of the object

[Jeff Xie]

Hi Masami,

On Sat, Jun 25, 2022 at 11:58 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Tue,  7 Jun 2022 00:09:41 +0800
> Jeff Xie <xiehuan09@xxxxxxxxx> wrote:
>
> > @@ -176,9 +275,27 @@ trace_object_trigger(struct event_trigger_data *data,
> >
> >       field = obj_data->field;
> >       memcpy(&obj, rec + field->offset, sizeof(obj));
> > -     set_trace_object(obj, tr);
> > +     /* set the offset from the special object and the type size of the value*/
> > +     set_trace_object(obj, obj_data->obj_offset,
> > +                     obj_data->obj_value_type_size, tr);
> >  }
> >
> > +static const struct objtrace_fetch_type objtrace_fetch_types[] = {
> > +     {"u8", 1},
> > +     {"s8", 1},
> > +     {"x8", 1},
> > +     {"u16", 2},
> > +     {"s16", 2},
> > +     {"x16", 2},
> > +     {"u32", 4},
> > +     {"s32", 4},
> > +     {"x32", 4},
> > +     {"u64", 8},
> > +     {"s64", 8},
> > +     {"x64", 8},
> > +     {NULL, 0},
> > +};
>
> As I said before, please use only 'uX' types at this moment,
> since the objtrace event doesn't show the value with sign.
> This means it only supports 'uX'.

Thanks, I will remove the 's' type in the next version.

> Thank you,
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks,
JeffXie