Re: [PATCH v13 4/5] arm64: dts: qcom: sc7180: Add pazquel dts files

[Krzysztof Kozlowski]

On 25/06/2022 16:45, Doug Anderson wrote:
> Hi,
> 
> On Fri, Jun 24, 2022 at 7:28 PM Joseph S. Barrera III
> <joebar@xxxxxxxxxxxx> wrote:
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> index e55dbaa6dc12..69cd4b3b911b 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> @@ -11,6 +11,12 @@
>>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>  #include <dt-bindings/sound/sc7180-lpass.h>
>>
>> +#ifdef __SC7180_TROGDOR_DTSI__
>> +#error "Duplicate include"
>> +#else
>> +#define __SC7180_TROGDOR_DTSI__
>> +#endif
>> +
> 
> I'm not convinced about the need for this. That being said:

We have several DTSI files included by several different boards. Some
are describing board (in a common way), some only common subset of board
or SoC. In none of the cases we include such include guard, so why is
this one different?

Best regards,
Krzysztof