Re: [PATCH v2 2/2] pinctrl: Add Cypress cy8c95x0 support

[Linus Walleij]

On Wed, Jun 15, 2022 at 12:50 PM Patrick Rudolph
<patrick.rudolph@xxxxxxxxxxxxx> wrote:

> Add support for cypress I2C GPIO expanders cy8c9520, cy8c9540 and
> cy8c9560. The GPIO expanders feature a PWM mode, thus add it as
> pinctrl driver.
>
> The chip features multiple drive modes for each pin when configured
> as output and multiple bias settings when configured as input.
>
> Tested all three components and verified that all functionality
> is fully working.
>
> Datasheet: https://www.cypress.com/file/37971/download
> Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>

Looks good to me, I see there are still some comments on the bindings,
once that is fixed this is good to go.

Yours,
Linus Walleij