Re: [RESEND PATCH] rtc: sun6i: add support for R329 RTC

From: Icenowy Zheng
Date: Sun Jun 26 2022 - 00:33:01 EST


在 2022-06-25星期六的 23:27 -0500,Samuel Holland写道:
> From: Icenowy Zheng <icenowy@xxxxxxx>
>
> Allwinner R329 has a RTC with a similar time storage with H616 but a
> slightly different clock part.
>
> As we have already handled the R329 RTC clocks in the CCU driver, add
> a
> compatible string to RTC driver to allow probing of the RTC.
>
> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
> Resending this patch separately from Icenowy's R329 series[1] because
> it
> is also needed for D1 (which has R329 as its fallback compatible[2]),
> so
> I would like to get it in to 5.20.

Thanks!

BTW when will you put D1 DTs into kernel?

>
> [1]:
> https://lore.kernel.org/lkml/BYAPR20MB2472C608678F3FAEDA7B7541BCF79@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> [2]:
> https://lore.kernel.org/lkml/20220203021736.13434-3-samuel@xxxxxxxxxxxx/
>
>  drivers/rtc/rtc-sun6i.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 57540727ce1c..ed5516089e9a 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -875,6 +875,8 @@ static const struct of_device_id
> sun6i_rtc_dt_ids[] = {
>         { .compatible = "allwinner,sun50i-h6-rtc" },
>         { .compatible = "allwinner,sun50i-h616-rtc",
>                 .data = (void *)RTC_LINEAR_DAY },
> +       { .compatible = "allwinner,sun50i-r329-rtc",
> +               .data = (void *)RTC_LINEAR_DAY },
>         { /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, sun6i_rtc_dt_ids);