Re: [PATCH] platform: x86: Remove duplicated include in barco-p50-gpio.c

From: Peter Korsgaard
Date: Sun Jun 26 2022 - 15:14:20 EST


>>>>> "Saurav" == Saurav Girepunje <saurav.girepunje@xxxxxxxxx> writes:

> Remove the duplicate include of linux/io.h in barco-p50-gpio.c
> file.

> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>

What tree is this against? The io.h include in the line just above
delay.h was already removed by:

commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
Author: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>
Date: Thu May 26 17:03:45 2022 +0800

platform/x86: barco-p50-gpio: Add check for platform_driver_register

As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.

Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>
Acked-by: Peter Korsgaard <peter.korsgaard@xxxxxxxxx>
Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@xxxxxxxxxxx
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/leds.h>
> #include <linux/module.h>
> --
> 2.33.0


--
Bye, Peter Korsgaard