Re: [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read()

From: Krzysztof Kozlowski
Date: Sun Jun 26 2022 - 16:02:32 EST


On 26/06/2022 21:56, Michael Walle wrote:
> Am 2022-06-26 21:51, schrieb Krzysztof Kozlowski:
>> On 26/06/2022 21:42, Michael Walle wrote:
>>> There are packets which doesn't have a payload. In that case, the
>>> second
>>> i2c_master_read() will have a zero length. But because the NFC
>>> controller doesn't have any data left, it will NACK the I2C read and
>>> -ENXIO will be returned. In case there is no payload, just skip the
>>> second i2c master read.
>>>
>>> Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI
>>> driver")
>>> Signed-off-by: Michael Walle <michael@xxxxxxxx>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Thanks, I'll reorder the patches in the next version otherwise
> there will likely be a conflict.

Yes.

> That should work with any patch
> tools (i.e. b4), shouldn't it?

You mean - re-ordering should work? Yes, no problem with that.

Best regards,
Krzysztof