Re: [PATCH V2 2/2] drm: xlnx: dsi: Add Xilinx MIPI DSI-Tx subsystem driver

From: kernel test robot
Date: Sun Jun 26 2022 - 18:45:00 EST


Hi Venkateshwar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on linus/master v5.19-rc3 next-20220624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Venkateshwar-Rao-Gannavarapu/Add-Xilinx-DSI-Tx-subsystem-DRM-driver/20220616-222008
base: git://anongit.freedesktop.org/drm/drm drm-next
config: mips-randconfig-c004-20220626
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b0d6dd3905db145853c7c744ac92d49b00b1fa20)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/28aa62ffdc1901029bf75961166f4ebba948b9b7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Venkateshwar-Rao-Gannavarapu/Add-Xilinx-DSI-Tx-subsystem-DRM-driver/20220616-222008
git checkout 28aa62ffdc1901029bf75961166f4ebba948b9b7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/xlnx/xlnx_dsi.c:255:10: error: label at end of compound statement: expected statement
default: /* define */
^
;
1 error generated.


vim +255 drivers/gpu/drm/xlnx/xlnx_dsi.c

227
228 #define MAX_INPUT_SEL_FORMATS 3
229 static u32
230 *xlnx_dsi_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
231 struct drm_bridge_state *bridge_state,
232 struct drm_crtc_state *crtc_state,
233 struct drm_connector_state *conn_state,
234 u32 output_fmt,
235 unsigned int *num_input_fmts)
236 {
237 u32 *input_fmts;
238 unsigned int i = 0;
239
240 *num_input_fmts = 0;
241 input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts), GFP_KERNEL);
242 if (!input_fmts)
243 return NULL;
244
245 switch (output_fmt) {
246 case MEDIA_BUS_FMT_FIXED:
247 input_fmts[i++] = MEDIA_BUS_FMT_RGB888_1X24;
248 break;
249 case MEDIA_BUS_FMT_RGB666_1X18:
250 input_fmts[i++] = MEDIA_BUS_FMT_RGB666_1X18;
251 break;
252 case MEDIA_BUS_FMT_RGB565_1X16:
253 input_fmts[i++] = MEDIA_BUS_FMT_RGB565_1X16;
254 break;
> 255 default: /* define */
256 }
257
258 *num_input_fmts = i;
259 if (*num_input_fmts == 0) {
260 kfree(input_fmts);
261 input_fmts = NULL;
262 }
263
264 return input_fmts;
265 }
266

--
0-DAY CI Kernel Test Service
https://01.org/lkp