Re: [PATCH] riscv: dts: align gpio-key node names with dtschema

From: Conor.Dooley
Date: Mon Jun 27 2022 - 02:52:17 EST




On 27/06/2022 07:48, Krzysztof Kozlowski wrote:
> On 26/06/2022 22:56, Conor.Dooley@xxxxxxxxxxxxx wrote:
>>
>>
>> On 24/06/2022 18:08, Krzysztof Kozlowski wrote:
>>> The node names should be generic and DT schema expects certain pattern
>>> (e.g. with key/button/switch).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> Are you planning to change them all & then change the pattern
>> property to complain if "key" is missing?
>
> Yes, I put the link to original patchset doing this:
>
>> Thanks,
>> Conor.
>>
>>>
>>> ---
>>>
>>> See: https://lore.kernel.org/all/20220616005224.18391-1-krzysztof.kozlowski@xxxxxxxxxx/
>
> Specifically one of the first patches:
> https://lore.kernel.org/all/20220616005333.18491-1-krzysztof.kozlowski@xxxxxxxxxx/
>

Ah my bad, I had a quick look and didn't see it.
I blame a long day of traveling!

Thanks,
Conor.