Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc

From: Lee Jones
Date: Mon Jun 27 2022 - 09:10:39 EST


On Thu, 16 Jun 2022, Andy Shevchenko wrote:

> The core part is misleading since its only purpose to serve Crystal Cove PMIC,
> although for couple of different platforms. Merge core part into crc one.
>
> Advantages among others are:
> - speed up a compilation and build
> - decreasing the code base
> - reducing noise in the namespace by making some data static and const
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/intel_soc_pmic_core.c | 160 -----------------------------
> drivers/mfd/intel_soc_pmic_core.h | 25 -----
> drivers/mfd/intel_soc_pmic_crc.c | 162 ++++++++++++++++++++++++++++--
> 4 files changed, 157 insertions(+), 193 deletions(-)
> delete mode 100644 drivers/mfd/intel_soc_pmic_core.c
> delete mode 100644 drivers/mfd/intel_soc_pmic_core.h

Can you submit this again with the -M flag please.

Trying to figure out what exactly changed is proving challenging.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog