Re: [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT

[Aurabindo Pillai]

On 2022-06-26 10:20, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
>
> Neither of thse variables is used in dc_link_dp.c.  Reviewing the commit listed in
> the fixes tag shows neither was used in the original patch.  So remove them.
>
> Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index be1dcb0a2a06..f3421f2bd52e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_
>   	return true;
>   }
>   
> -bool FORCE_RATE = false;
> -uint32_t FORCE_LANE_COUNT = 0;
> -
>   void decide_link_settings(struct dc_stream_state *stream,
>   	struct dc_link_settings *link_setting)
>   {


Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>