Re: [PATCH v3] dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC
From: Rob Herring
Date: Mon Jun 27 2022 - 09:31:38 EST
On Sun, 26 Jun 2022 21:16:30 +0200, David Heidelberg wrote:
> Convert Qualcomm SPMI PMIC binding to yaml format.
>
> Additional changes:
> - filled many missing compatibles
>
> Co-developed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> v3:
> - added subnodes, there are two not converted to YAML yet, but it works
> - now it prints milion directly unrelated warning to this binding
> (it's related to the included subnodes bindings, can be merged,
> but it'll generate more warnings and preferably anyone can takeover
> from here)
> - add qcom,pmx65
>
> v2:
> - changed author to myself, kept Caleb as co-author
> - moved nodename to properties
> - add nodenames for pm* with deprecated property
> - add ^$ to pattern properties
> - dropped interrupt-names property
> - added reg prop. to the nodes which have register in nodename
> - added compatible pmx55
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> .../bindings/mfd/qcom,spmi-pmic.txt | 94 ---------
> .../bindings/mfd/qcom,spmi-pmic.yaml | 191 ++++++++++++++++++
> 2 files changed, 191 insertions(+), 94 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom,spmi-temp-alarm.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.