Re: [PATCH v2 1/1] serial: core: Start managing serial controllers to enable runtime PM

[Tony Lindgren]

* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [220627 12:23]:
> On Wed, Jun 15, 2022 at 09:24:55AM +0300, Tony Lindgren wrote:
> > We want to enable runtime PM for serial port device drivers in a generic
> > way. To do this, we want to have the serial core layer manage the
> > registered serial port controllers. For runtime PM, we need a way to find
> > the serial ports for each serial port controller device.
> > 
> > The serial core manages ports. Each serial controller can have multiple
> > ports. As serial core has no struct device, and the serial port device
> > drivers have their own driver data, we cannot currently start making
> > use of serial core generic data easily without changing all the serial
> > port device drivers.
> 
> Really?  Why not make struct uart_port a real struct device?

Okie dokie

> > We could consider adding a serial core specific struct device. It would
> > be a child of the serial port device, and would allow us eventually to use
> > device_links to add generic runtime PM calls for example. But as the serial
> > core layer is not a device driver, driver specific features would need to
> > be added, and are probably not justified for a virtual device.
> 
> I think it's very justified, let's not paper over this whole thing by
> adding a kref stuck in in the middle and trying to hook up the PM code
> to it, instead of just using all of the PM logic that the driver model
> already provides.

OK. Having the serial controller be the parent device for the port device
will make runtime PM work as designed :)

> > Considering the above, let's improve the serial core layer so we can
> > manage the serial port controllers better. Let's register the controllers
> > with the serial core layer in addition to the serial ports.
> 
> Why can't controllers be a device as well?

The controllers are devices already probed by the serial port drivers.
What's missing is mapping the ports (as devices based on the comments
above) to the controller devices. I don't think we need another struct
device for the serial controller in addition to the serial port driver
device and it's child port devices.

> Let's try to work with the driver model here, not work around it, if at
> all possible.  We never did a full conversion of the serial layer to the
> driver core all those decades ago.  Perhaps now is the time to really do
> that.

Yes so it seems.

Regards,

Tony