Re: [v3 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec
From: Matthias Kaehlcke
Date: Mon Jun 27 2022 - 12:00:06 EST
On Sat, Jun 25, 2022 at 09:50:57PM -0500, Bjorn Andersson wrote:
> On Tue 24 May 20:43 CDT 2022, Judy Hsiao wrote:
>
> > Put sound node and lpass_cpu node settings for boards that use rt5682
> > codec in the sc7280-herobrine-audio-rt5682.dtsi as there are different
> > choices of headset codec for herobrine projects. Common audio setting
> > for the internal speaker is in sc7280-herobrine.dtsi.
> >
> > This series depends on:
> > "Add lpass pin control support for audio on sc7280 based targets" [1]
> > "Add soundcard support for sc7280 based platforms" [2]
> >
> > [1]
> > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
>
> Afaict this is applied.
>
> > [2]
> > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=643589
> >
>
> But [2] doesn't compile and hence this series doesn't compile.
If I'm not mistaken the main contender is the "Add support for audio clock
gating resets for SC7280" series [1], which still has open comments.
[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=650267
> Can you please submit a single series with all the audio dts patches you
> want me to apply, where it's possible to run "make dtbs" after every
> single patch in the series.
>
> Thanks,
> Bjorn
>
> >
> > Changes Since V2:
> > -- Add bias-disable for i2s ws line.
> > -- Fix typo in the commit message.
> >
> > Changes Since V1:
> > -- Remove sound-dai-cells in sound node.
> > -- Add dependency list.
> > -- Update patch subject.
> >
> > Judy Hsiao (3):
> > arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
> > arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
> > arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi
> > in villager and herobrine-r1
> >
> > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 121 ++++++++++++++++++
> > .../qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
> > .../dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
> > .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 15 +++
> > 4 files changed, 138 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> >
> > --
> > 2.36.1.124.g0e6072fb45-goog
> >