Re: [PATCH] vfio: de-extern-ify function prototypes

From: Alex Williamson
Date: Mon Jun 27 2022 - 12:36:02 EST


On Fri, 10 Jun 2022 16:44:07 -0600
Alex Williamson <alex.williamson@xxxxxxxxxx> wrote:

> On Thu, 9 Jun 2022 21:04:34 -0300
> Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
>
> > On Wed, Jun 08, 2022 at 12:55:13PM -0600, Alex Williamson wrote:
> > > The use of 'extern' in function prototypes has been disrecommended in
> > > the kernel coding style for several years now, remove them from all vfio
> > > related files so contributors no longer need to decide between style and
> > > consistency.
> > >
> > > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> > > ---
> > >
> > > A patch in the same vein was proposed about a year ago, but tied to an ill
> > > fated series and forgotten. Now that we're at the beginning of a new
> > > development cycle, I'd like to propose kicking off the v5.20 vfio next
> > > branch with this patch and would kindly ask anyone with pending respins or
> > > significant conflicts to rebase on top of this patch. Thanks!
> >
> > Can you stick it in your branch please?
>
> Thanks for the R-b, it was my plan today to put it in my next branch,
> but I can't currently test vfio on mainline due to:
>
> https://lore.kernel.org/all/165490039431.944052.12458624139225785964.stgit@omen/
>
> I'll get this in once there's a mainline base where vfio still works. Thanks,

This has now been resolved in rc4 via 034e5afad921 ("mm: re-allow
pinning of zero pfns"). I've rebased to rc4 and pushed this patch out
to the vfio next branch. Thanks,

Alex