Re: [PATCH][next] NTB: EPF: set pointer addr to null using NULL rather than 0
From: Bjorn Helgaas
Date: Mon Jun 27 2022 - 16:29:26 EST
On Thu, Jun 23, 2022 at 05:57:09PM +0100, Colin Ian King wrote:
> The pointer addr is being set to null using 0. Use NULL instead.
>
> Cleans up sparse warning:
> warning: Using plain integer as NULL pointer
Another one for Jon; fixes this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ff32fac00d97
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index ebf7e243eefa..fb31c868af6a 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -605,7 +605,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb)
>
> ntb->epf->bar[barno].barno = barno;
> ntb->epf->bar[barno].size = size;
> - ntb->epf->bar[barno].addr = 0;
> + ntb->epf->bar[barno].addr = NULL;
> ntb->epf->bar[barno].phys_addr = 0;
> ntb->epf->bar[barno].flags |= upper_32_bits(size) ?
> PCI_BASE_ADDRESS_MEM_TYPE_64 :
> --
> 2.35.3
>