Re: [PATCH] ARM: OMAP2+: Fix refcount leak in omapdss_init_of
From: Tony Lindgren
Date: Tue Jun 28 2022 - 00:37:25 EST
* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [220601 06:46]:
> Hello Lin,
>
> Thank you for the patch.
>
> On Wed, Jun 01, 2022 at 08:48:58AM +0400, Miaoqian Lin wrote:
> > omapdss_find_dss_of_node() calls of_find_compatible_node() to get device
> > node. of_find_compatible_node() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when done.
> > Add missing of_node_put() in later error path and normal path.
> >
> > Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> > Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks applying this into omap-for-v5.20/soc.
Regards,
Tony