Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks.

[Krishna Chaitanya Chundru]

On 6/24/2022 10:28 PM, Bjorn Helgaas wrote:
> On Fri, Jun 24, 2022 at 02:49:50PM +0530, Krishna chaitanya chundru wrote:
> > Add missing clocks.
> When you revise this, please make your subject line match the history:
>
>    dt-bindings: PCI: qcom: Add schema for sc7280 chipset
>    dt-bindings: PCI: qcom: Specify reg-names explicitly
>    dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms
>    dt-bindings: PCI: qcom: Convert to YAML
>
> So your subject line should be something like:
>
>    dt-bindings: PCI: qcom: Add sc7280 aggre0 and aggre1 clocks
>
> Please also include the names of the clocks you're adding in the
> commit log.  This will make the commit log history more specific and
> useful for future readers.
>
> This also applies to the other patches.
Thanks Bjorn, I will try to incorporate your comments in the next patch.
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index 0b69b12..313b981 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -438,6 +438,8 @@ allOf:
> >               - const: slave_q2a # Slave Q2A clock
> >               - const: tbu # PCIe TBU clock
> >               - const: ddrss_sf_tbu # PCIe SF TBU clock
> > +            - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock
> > +            - const: aggre1 # Aggre NoC PCIe1 AXI clock
> I assume the stuff after "#" is comment and could thus be made
> consistent: s/PCIE/PCIe/, is "PCIe1" a typo for "PCIe" or different?
> Seems like weird/inconsistent capitalization in general ("CENTER"),
> but if you're matching language in a spec, please do that and ignore
> my comment :)
>
> >           resets:
> >             maxItems: 1
> >           reset-names:
> > --
> > 2.7.4