Re: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio

[Andy Shevchenko]

On Fri, Jun 24, 2022 at 2:07 PM Marcus Folkesson
<marcus.folkesson@xxxxxxxxx> wrote:
> On Thu, Jun 23, 2022 at 09:20:01PM +0200, Andy Shevchenko wrote:
> > On Thu, Jun 23, 2022 at 9:08 PM Marcus Folkesson
> > <marcus.folkesson@xxxxxxxxx> wrote:

...

> > > +static const int mcp3911_osr_table[] = {32, 64, 128, 256, 512, 1024, 2048, 4096};
> >
> > Spaces inside {}.
>
> Not sure what you mean?

   int foo = { 1, 2, 3 };

...

> > > +               ret = mcp3911_update(adc, MCP3911_REG_CONFIG,
> > > +                               MCP3911_CONFIG_OSR,
> > > +                               val, 2);
> >
> > sizeof() ?
>
> sizeof() what?

sizeof(val) ?

-- 
With Best Regards,
Andy Shevchenko