[PATCH] net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw_probe()

From: Peng Wu
Date: Tue Jun 28 2022 - 09:15:41 EST


The devm_platform_ioremap_resource() function never returns NULL.
It returns error pointers.

Signed-off-by: Peng Wu <wupeng58@xxxxxxxxxx>
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
---
drivers/net/dsa/rzn1_a5psw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
index 3e910da98ae2..5b14e2ba9b79 100644
--- a/drivers/net/dsa/rzn1_a5psw.c
+++ b/drivers/net/dsa/rzn1_a5psw.c
@@ -946,8 +946,8 @@ static int a5psw_probe(struct platform_device *pdev)
mutex_init(&a5psw->lk_lock);
spin_lock_init(&a5psw->reg_lock);
a5psw->base = devm_platform_ioremap_resource(pdev, 0);
- if (!a5psw->base)
- return -EINVAL;
+ if (IS_ERR(a5psw->base))
+ return PTR_ERR(a5psw->base);

ret = a5psw_pcs_get(a5psw);
if (ret)
--
2.17.1