Re: [PATCH v3] ipv6/sit: fix ipip6_tunnel_get_prl return value

From: David Ahern
Date: Tue Jun 28 2022 - 11:05:15 EST


On 6/27/22 9:50 PM, zys.zljxml@xxxxxxxxx wrote:
> From: katrinzhou <katrinzhou@xxxxxxxxxxx>
>
> When kcalloc fails, ipip6_tunnel_get_prl() should return -ENOMEM.
> Move the position of label "out" to return correctly.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL ioctl to get/dump PRL.")
> Signed-off-by: katrinzhou <katrinzhou@xxxxxxxxxxx>
> ---
>
> Changes in v2:
> - Move the position of label "out"
>
> Changes in v3:
> - Modify commit message
>
> net/ipv6/sit.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>