Re: [PATCH for-next 2/8] io_uring: restore bgid in io_put_kbuf
From: Jens Axboe
Date: Tue Jun 28 2022 - 11:13:30 EST
On 6/28/22 9:02 AM, Dylan Yudaken wrote:
> Attempt to restore bgid. This is needed when recycling unused buffers as
> the next time around it will want the correct bgid.
>
> Signed-off-by: Dylan Yudaken <dylany@xxxxxx>
> ---
> io_uring/kbuf.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/io_uring/kbuf.h b/io_uring/kbuf.h
> index 3d48f1ab5439..c64f02ea1c30 100644
> --- a/io_uring/kbuf.h
> +++ b/io_uring/kbuf.h
> @@ -96,16 +96,20 @@ static inline void io_kbuf_recycle(struct io_kiocb *req, unsigned issue_flags)
> static inline unsigned int __io_put_kbuf_list(struct io_kiocb *req,
> struct list_head *list)
> {
> + unsigned int ret = IORING_CQE_F_BUFFER | (req->buf_index << IORING_CQE_BUFFER_SHIFT);
> if (req->flags & REQ_F_BUFFER_RING) {
Should have a newline here after the 'ret' variable declaration.
--
Jens Axboe