Re: [PATCH 2/2] vfs: escape hash as well

From: Al Viro
Date: Tue Jun 28 2022 - 13:57:41 EST


On Tue, Jun 28, 2022 at 08:30:58AM +0800, Ian Kent wrote:
> From: Siddhesh Poyarekar <siddhesh@xxxxxxxxxx>
>
> When a filesystem is mounted with a name that starts with a #:
>
> # mount '#name' /mnt/bad -t tmpfs
>
> this will cause the entry to look like this (leading space added so
> that git does not strip it out):
>
> #name /mnt/bad tmpfs rw,seclabel,relatime,inode64 0 0
>
> This breaks getmntent and any code that aims to parse fstab as well as
> /proc/mounts with the same logic since they need to strip leading spaces
> or skip over comment lines, due to which they report incorrect output or
> skip over the line respectively.
>
> Solve this by translating the hash character into its octal encoding
> equivalent so that applications can decode the name correctly.
>
> Signed-off-by: Siddhesh Poyarekar <siddhesh@xxxxxxxxxx>
> Signed-off-by: Ian Kent <raven@xxxxxxxxxx>

ACK; I'll grab that one (in #work.misc - I don't believe it's #fixes
fodder).