Re: [PATCH v5 02/22] cc_platform: Add new attribute to prevent ACPI CPU hotplug

From: Kai Huang
Date: Tue Jun 28 2022 - 19:41:35 EST


On Tue, 2022-06-28 at 19:33 +0200, Rafael J. Wysocki wrote:
> > Hi Rafael,
> >
> > I am not sure I got what you mean by "This will affect initialization, not
> > just
> > hotplug AFAICS", could you elaborate a little bit?  Thanks.
>
> So acpi_processor_add() is called for CPUs that are already present at
> init time, not just for the hot-added ones.
>
> One of the things it does is to associate an ACPI companion with the given
> CPU.
>
> Don't you need that to happen?

You are right. I did test again and yes it was also called after boot-time
present cpus are up (after smp_init()). I didn't check this carefully at my
previous test. Thanks for catching.

--
Thanks,
-Kai