[gfs2:nopid 1/5] fs/gfs2/glock.c:2785:3: error: call to undeclared function 'fput'; ISO C99 and later do not support implicit function declarations
From: kernel test robot
Date: Tue Jun 28 2022 - 22:01:49 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git nopid
head: b1d0ed94e881ca5b5aee15e05f13db75445398f2
commit: 13ba8572506201aa85020970f776597fbcdcda56 [1/5] gfs2: Add glockfd debugfs file
config: arm64-buildonly-randconfig-r005-20220627 (https://download.01.org/0day-ci/archive/20220629/202206290953.iT9zAjZQ-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=13ba8572506201aa85020970f776597fbcdcda56
git remote add gfs2 https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
git fetch --no-tags gfs2 nopid
git checkout 13ba8572506201aa85020970f776597fbcdcda56
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash fs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> fs/gfs2/glock.c:2785:3: error: call to undeclared function 'fput'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
fput(i->file);
^
fs/gfs2/glock.c:2842:3: error: call to undeclared function 'fput'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
fput(i->file);
^
2 errors generated.
vim +/fput +2785 fs/gfs2/glock.c
2781
2782 static struct file *gfs2_glockfd_next_file(struct gfs2_glockfd_iter *i)
2783 {
2784 if (i->file) {
> 2785 fput(i->file);
2786 i->file = NULL;
2787 }
2788
2789 rcu_read_lock();
2790 for(;; i->fd++) {
2791 struct inode *inode;
2792
2793 i->file = task_lookup_next_fd_rcu(i->task, &i->fd);
2794 if (!i->file) {
2795 i->fd = 0;
2796 break;
2797 }
2798 inode = file_inode(i->file);
2799 if (inode->i_sb != i->sb)
2800 continue;
2801 if (get_file_rcu(i->file))
2802 break;
2803 }
2804 rcu_read_unlock();
2805 return i->file;
2806 }
2807
--
0-DAY CI Kernel Test Service
https://01.org/lkp