Re: [PATCH v7 1/2] dt-bindings: iio: adc: add AD4130

From: Rob Herring
Date: Tue Jun 28 2022 - 22:09:48 EST

Next message: Rob Herring: "Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema"
Previous message: Lei Rao: "[PATCH] vfio: Fix memory leaks in vfio_create_group()"
In reply to: Cosmin Tanislav: "[PATCH v7 1/2] dt-bindings: iio: adc: add AD4130"
Next in thread: Rob Herring: "Re: [PATCH v7 1/2] dt-bindings: iio: adc: add AD4130"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 28 Jun 2022 17:46:48 +0300, Cosmin Tanislav wrote:
> AD4130-8 is an ultra-low power, high precision, measurement solution for
> low bandwidth battery operated applications.
>
> The fully integrated AFE (Analog Front-End) includes a multiplexer for up
> to 16 single-ended or 8 differential inputs, PGA (Programmable Gain
> Amplifier), 24-bit Sigma-Delta ADC, on-chip reference and oscillator,
> selectable filter options, smart sequencer, sensor biasing and excitation
> options, diagnostics, and a FIFO buffer.
>
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> ---
> .../bindings/iio/adc/adi,ad4130.yaml | 256 ++++++++++++++++++
> 1 file changed, 256 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,excitation-current-1-nanoamp: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default', 'enum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default' was unexpected)
hint: A vendor string property with exact values has an implicit type
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,excitation-current-1-nanoamp: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
0 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
100 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
10000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
20000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
50000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
100000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
150000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
200000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,burnout-current-nanoamp: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default', 'enum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default' was unexpected)
hint: A vendor string property with exact values has an implicit type
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,burnout-current-nanoamp: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
0 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
500 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
2000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
4000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,excitation-current-0-nanoamp: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default', 'enum' were unexpected)
hint: A vendor boolean property can use "type: boolean"
Additional properties are not allowed ('default' was unexpected)
hint: A vendor string property with exact values has an implicit type
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: patternProperties:^channel@([0-9a-f])$:properties:adi,excitation-current-0-nanoamp: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
0 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
100 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
10000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
20000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
50000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
100000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
150000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
200000 is not of type 'string'
hint: A vendor string property with exact values has an implicit type
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,excitation-current-1-nanoamp
Documentation/devicetree/bindings/iio/adc/adi,ad4130.example.dtb:0:0: /example-0/spi/adc@0: failed to match any schema with compatible: ['adi,ad4130']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Next message: Rob Herring: "Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema"
Previous message: Lei Rao: "[PATCH] vfio: Fix memory leaks in vfio_create_group()"
In reply to: Cosmin Tanislav: "[PATCH v7 1/2] dt-bindings: iio: adc: add AD4130"
Next in thread: Rob Herring: "Re: [PATCH v7 1/2] dt-bindings: iio: adc: add AD4130"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]