Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy

[Wangseok Lee]

Just a gentle ping for this patch, if any concern on this patch please let me know.


On 20/06/2022 17:38, Wangseok Lee wrote:
> On 17/06/2022 07:59, Krzysztof Kozlowski wrote:
>> On 13/06/2022 18:29, Wangseok Lee wrote:
>>> Signed-off-by: Wangseok Lee <wangseok.lee@xxxxxxxxxxx>
>>> ---
>>> v2->v3 :
>>> -modify version history to fit the linux commit rule
>>> -remove 'Device Tree Bindings' on title
>>> -remove clock-names entries
>>> -change node name to soc from artpec8 on excamples
>>> 
>>> v1->v2 :
>>> -'make dt_binding_check' result improvement
>>> -Add the missing property list
>>> -Align the indentation of continued lines/entries
>>> ---
>>>  .../bindings/phy/axis,artpec8-pcie-phy.yaml        | 73 ++++++++++++++++++++++
>>>  1 file changed, 73 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml
>>> 
>>> diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml
>>> new file mode 100644
>>> index 0000000..316b774
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml
>>> @@ -0,0 +1,73 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: https://protect2.fireeye.com/v1/url?k=84f6a8c0-e57dbdd9-84f7238f-74fe485cbfec-e81bd79bfd1ff442&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Faxis%2Cartpec8-pcie-phy.yaml%23
>>> +$schema: https://protect2.fireeye.com/v1/url?k=b4f1a4ba-d57ab1a3-b4f02ff5-74fe485cbfec-7f885cbe82dc7860&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>>> +
>>> +title: ARTPEC-8 SoC PCIe PHY
>>> +
>>> +maintainers:
>>> +  - Jesper Nilsson <jesper.nilsson@xxxxxxxx>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: axis,artpec8-pcie-phy
>>> +
>>> +  reg:
>>> +    items:
>>> +      - description: PHY registers.
>>> +      - description: PHY coding sublayer registers.
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: phy
>>> +      - const: pcs
>>> +
>>> +  "#phy-cells":
>>> +    const: 0
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: PCIe PHY reference clock
> 
> refer to sample-schema.yaml, even if the clock item is single,
> it seems to be used as follows.
> 
> clocks:
>   maxItems: 1
> 
> clock-names:
>   items:
>     - const: ref
> 
> If only "clocks:" are define and clock-names are not define,
> the following warning occurs.
> "'clock-names' does not match any of the regexes"
> 
>>> +
>>> +  num-lanes:
>>> +    const: 2
>>> +
>>> +  lcpll-ref-clk:
>>> +    const: 1
>> 
>> Unknown field... custom properties need vendor (axis,), type (boolean)
>> and description.
>> 
> 
> "lcpl-ref-clk" has an enum type value, so i will modify it as below.
> 
> 
> axis,lcpll-ref-clk:
>   description:
>     select the reference clock of phy and initialization is performed
>     with the reference clock according to the selected value.
>   $ref: /schemas/types.yaml#/definitions/uint32
>   enum: [ 0, 1, 2, 3, 4 ]
> 
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - reg-names
>>> +  - "#phy-cells"
>>> +  - clocks
>>> +  - clock-names
>>> +  - samsung,fsys-sysreg
>> 
>> Same problem as in patch #1.
>> 
> 
> I will add the following items to the property.
> 
> samsung,fsys-sysreg:
>   description:
>     Phandle to system register of fsys block.
>   $ref: /schemas/types.yaml#/definitions/phandle
> 
>>> +  - num-lanes
>>> +  - lcpll-ref-clk
>>> +
>>> +additionalProperties: true
>> 
>> No, this must be false.
>> 
> 
> yes, i miss it. I will fix this.
> 
>> Best regards,
>> Krzysztof
> 
> Thank you for kindness reivew.
> 
> Best regards,
> Wangseok Lee