RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
From: Hennerich, Michael
Date: Wed Jun 29 2022 - 04:40:59 EST
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Dienstag, 28. Juni 2022 21:39
> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-
> gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski <brgl@xxxxxxxx>
> Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
>
>
> Sort header inclusion alphabetically.
Hi Andy,
Thanks for the patches, they look good.
However, Nuno is currently working on getting the irqchip support into the
adp5588 input driver. In his patch series this driver is going away.
https://lore.kernel.org/linux-input/YpMCh1Xje+jsny8j@xxxxxxxxxx/
Michael
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-adp5588.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index
> d6a229a67044..d49f12560cde 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -6,15 +6,15 @@
> * Copyright 2009-2010 Analog Devices Inc.
> */
>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/init.h>
> -#include <linux/i2c.h>
> #include <linux/gpio/driver.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> +#include <linux/kernel.h>
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> +#include <linux/slab.h>
>
> #include <linux/platform_data/adp5588.h>
>
> --
> 2.35.1