Re: [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device for properties

[Andy Shevchenko]

On Wed, Jun 29, 2022 at 1:41 AM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote:
>
> On Tue, Jun 28, 2022 at 3:01 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jun 15, 2022 at 02:47:45PM +0300, Andy Shevchenko wrote:
> > > It's not correct to use artificial device created by IIO core to
> > > retrieve device properties. Even ->get_default_reg() callback
> > > takes a simple struct device pointer which suggests it wants to
> > > operate on the real device.
> > >
> > > Correct this by replacing pointer to IIO device by a real device
> > > pointer in the caller of ->get_default_reg().
> >
> > Gwendal, any comments on this version?
> We can also replace '&indio_dev->dev' with 'dev' when setting
> ACPI_COMPANION_SET() in the probe routine.

It would make no sense, IIUC. In any case, the second patch in the
series, which was the same in v1 removes that completely.

> Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>

Thanks!

-- 
With Best Regards,
Andy Shevchenko