RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically

From: Sa, Nuno
Date: Wed Jun 29 2022 - 06:40:11 EST




> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Wednesday, June 29, 2022 12:33 PM
> To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>
> Cc: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Andy
> Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-
> gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski <brgl@xxxxxxxx>
> Subject: Re: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
> alphabetically
>
> [External]
>
> On Wed, Jun 29, 2022 at 12:10 PM Sa, Nuno <Nuno.Sa@xxxxxxxxxx>
> wrote:
> > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > > Sent: Wednesday, June 29, 2022 12:00 PM
> > > On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael
> > > <Michael.Hennerich@xxxxxxxxxx> wrote:
> > > > > -----Original Message-----
> > > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > > Sent: Dienstag, 28. Juni 2022 21:39
>
> ...
>
> > > > > Sort header inclusion alphabetically.
> > > >
> > > > Thanks for the patches, they look good.
> > > > However, Nuno is currently working on getting the irqchip
> support
> > > into the
> > > > adp5588 input driver. In his patch series this driver is going away.
> > > >
> > > > https://urldefense.com/v3/__https://lore.kernel.org/linux-
> > >
> input/YpMCh1Xje*jsny8j@xxxxxxxxxx/__;Kw!!A3Ni8CS0y2Y!_Cb1uAs
> > > D-
> > >
> Z6iz_zSDfrd5Va6zLmdoxjv1vLYWQGHDOqYniaXVVHl3Ou2lOUQIjwhSN
> > > Ku2aZkYrOb8xMi2cZtfmsv$
> > >
> > > While that work is ongoing, and most likely won't make v5.20-rc1,
> for
> > > the v5.20-rc1 I think my patches are good to go to avoid a bad (or
> > > rather very old) example on how to do GPIO drivers. What do you
> > > think?
> >
> > Just as note, If nothing unexpected happens, I'm planning in sending
> this
> > out today. If you still think this makes sense, fine by me. It's a very
> minimal
> > change that won't give much pain to deal with...
>
> Ah, Okay, I was thinking about a week or two from now. Let's see how
> it will go and let Linus decide how to proceed.
>

Yeah, if it does not happen today, I will only get into it again next
Wednesday (so in this case, might make sense).

- Nuno Sá