Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support
From: Marc Zyngier
Date: Wed Jun 29 2022 - 09:14:02 EST
On Mon, 27 Jun 2022 12:39:53 +0100,
Jianmin Lv <lvjianmin@xxxxxxxxxxx> wrote:
>
> From: Huacai Chen <chenhuacai@xxxxxxxxxxx>
>
> We are preparing to add new Loongson (based on LoongArch, not compatible
> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> as its boot protocol, so add ACPI init support.
>
> LIOINTC stands for "Legacy I/O Interrupts" that described in Section
> 11.1 of "Loongson 3A5000 Processor Reference Manual". For more
> information please refer Documentation/loongarch/irq-chip-model.rst.
This is what happens with this series while compiling for MIPS:
drivers/irqchip/irq-loongson-liointc.c: In function ‘liointc_domain_xlate’:
drivers/irqchip/irq-loongson-liointc.c:170:28: error: ‘GSI_MIN_CPU_IRQ’ undeclared (first use in this function)
170 | *out_hwirq = intspec[0] - GSI_MIN_CPU_IRQ;
| ^~~~~~~~~~~~~~~
I haven't bothered reviewing more patches, as this is a waste of my
time.
M.
--
Without deviation from the norm, progress is not possible.