Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

From: Wolfram Sang
Date: Wed Jun 29 2022 - 15:44:47 EST


On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
>
> That is clear from the diff, but why. Some chips don't have a reset?
> If so, this should be combined with patch 2 as part of changes needed
> for a new version.

What do you mean? Patches 1+2 should be squashed together? I can do this
when applying. Or do you mean something else?

>
> >
> > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> > - compatible
> > - reg
> > - interrupts
> > - - resets
> > - clocks
> >
> > unevaluatedProperties: false
> > --
> > 2.25.1
> >
> >

Attachment: signature.asc
Description: PGP signature