Re: [PATCH] remove CONFIG_ANDROID

From: Jason A. Donenfeld
Date: Wed Jun 29 2022 - 20:30:25 EST


Hey again,

On Thu, Jun 30, 2022 at 2:24 AM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> 1) Introduce a simple CONFIG_PM_CONTINUOUS_AUTOSLEEPING Kconfig thing
> with lots of discouraging help text.
>
> 2) Go with the /sys/power tunable and bikeshed the naming of that a bit
> to get it to something that reflects this better, and document it as
> being undesirable except for Android phones.

One other quick thought, which I had mentioned earlier to Kalesh:

3) Make the semantics a process holding open a file descriptor, rather
than writing 0/1 into a file. It'd be called /sys/power/
userspace_autosleep_ctrl, or something, and it'd enable this behavior
while it's opened. And maybe down the line somebody will want to add
ioctls to it for a different purpose. This way it's less of a tunable
and more of an indication that there's a userspace app doing/controlling
something.

This idea (3) may be a lot of added complexity for basically nothing,
but it might fit the usage semantics concerns a bit better than (2). But
anyway, just an idea. Any one of those three are fine with me.

Jason