Re: [PATCH 4.19 v1 1/2] hwmon: Introduce hwmon_device_register_for_thermal

From: Guenter Roeck
Date: Wed Jun 29 2022 - 22:31:19 EST


On 6/29/22 16:18, William McVicker wrote:
On 06/29/2022, Guenter Roeck wrote:
On 6/29/22 15:58, Will McVicker wrote:
From: Guenter Roeck <linux@xxxxxxxxxxxx>

[ upstream commit e5d21072054fbadf41cd56062a3a14e447e8c22b ]

The thermal subsystem registers a hwmon driver without providing
chip or sysfs group information. This is for legacy reasons and
would be difficult to change. At the same time, we want to enforce
that chip information is provided when registering a hwmon device
using hwmon_device_register_with_info(). To enable this, introduce
a special API for use only by the thermal subsystem.

Acked-by: Rafael J . Wysocki <rafael@xxxxxxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

NACK. The patch introducing the problem needs to be reverted.

I'm fine with that as well. I've already verified that fixes the issue. I'll go
ahead and send the revert.


My understanding is that it is already queued up.

Guenter