Re: [PATCH 2/4] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c

From: Bjorn Andersson
Date: Wed Jun 29 2022 - 23:55:03 EST


On Mon 30 May 02:06 CDT 2022, Pavel Machek wrote:

> Hi!
>
> > The DB845c has 4 "user LEDs", the last one is already supported as it's
> > just wired to a gpio. Now that the LPG binding is in place we can wire
> > up the other 3 LEDs as well.
>
>
> > +&pmi8998_lpg {
> > + status = "okay";
> > +
> > + qcom,power-source = <1>;
> > +
> > + led@3 {
> > + reg = <3>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_HEARTBEAT;
> > + function-enumerator = <3>;
> > +
> > + linux,default-trigger = "heartbeat";
> > + default-state = "on";
> > + };
> > +
> > + led@4 {
> > + reg = <4>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_INDICATOR;
> > + function-enumerator = <2>;
> > + };
> > +
> > + led@5 {
> > + reg = <5>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_INDICATOR;
> > + function-enumerator = <1>;
> > + };
>
> Do the LEDs have some kind of markings? Marking them as "indicator" is not too useful.
>

Unfortunately no, there is just 4 green LEDs tightly packed together (3
driven by the lpg, 1 by a gpio), with no indications of which is which.

Regards,
Bjorn