Re: [PATCH] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables

From: Mark Brown
Date: Thu Jun 30 2022 - 07:46:29 EST


On Wed, 29 Jun 2022 14:53:45 -0400, Tom Rix wrote:
> sparse reports
> sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static?
> sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?
>
> Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c,
> so their storage class specifiers should be static.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables
commit: d2294461b90e0c5b3bbfaaf2c8baff4fd3e2bb13

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark