Re: [PATCH v1 2/3] gpio: adp5588: Do not use defined value for driver name and compatible

[Linus Walleij]

On Tue, Jun 28, 2022 at 9:39 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> It's wrong to use defined string literal for three semantically different
> cases, i.e.:
> 1) compatible string, which is part of ABI and has to have specific format;
> 2) I2C ID, which is user space visible and also ABI;
> 3) driver name, that can be changed.
>
> Drop the define and use appropriate string literals in place.
>
> While at it, drop comma at terminator entry of OF ID table.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij