Re: [PATCH v6 02/14] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file
From: Viorel Suman (OSS)
Date: Thu Jun 30 2022 - 08:38:19 EST
On 22-06-29 19:53:51, Krzysztof Kozlowski wrote:
> On 29/06/2022 18:44, Viorel Suman (OSS) wrote:
> > From: Abel Vesa <abel.vesa@xxxxxxx>
> >
> > In order to replace the fsl,scu txt file from bindings/arm/freescale,
> > we need to split it between the right subsystems. This patch documents
> > separately the 'iomux/pinctrl' child node of the SCU main node.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> > ---
> > .../bindings/pinctrl/fsl,scu-pinctrl.yaml | 68 +++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> > new file mode 100644
> > index 000000000000..76a2e7b28172
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
[...]
> > + fsl,pins:
> > + description:
> > + each entry consists of 3 integers and represents the pin ID, the mux value
> > + and config setting for the pin. The first 2 integers - pin_id and mux_val - are
> > + specified using a PIN_FUNC_ID macro, which can be found in
> > + <include/dt-bindings/pinctrl/pads-imx8qxp.h>. The last integer CONFIG is
> > + the pad setting value like pull-up on this pin. Please refer to the
> > + appropriate i.MX8 Reference Manual for detailed CONFIG settings.
> > + $ref: /schemas/types.yaml#/definitions/uint32-matrix
>
> Look at fsl,imx8mq-pinctrl.yaml. Each item is described (items under items).
Added them initially, but later dropped because of some logs like
"pinctrl@xxxxxxx: usdhc1grp:fsl,pins:0: [...] is too long" shown by
"make dt_binding_check dtbs_check DT_SCHEMA_FILES=[...]/fsl,scu-pinctrl.yaml"
Same logs are shown for "fsl,imx8mq-pinctrl.yaml". Will add the items description in the next
version.
Thank you,
Viorel