Re: [PATCH] irqchip/xilinx: add explicit dependency on OF_ADDRESS

[Marc Zyngier]

On 2022-06-30 13:33, Michal Simek wrote:
> On 6/30/22 13:10, Jamie Iles wrote:
> > Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
> > dependency") relaxed the dependencies on the Xilinx interrupt 
> > controller
> > to be OF only, but some OF architectures (s390 for example) do not
> > support OF_ADDRESS and so a build of the driver will result in 
> > undefined
> > references to of_iomap/iounmap and friends.
>
> Can you please add here fixed tag?
>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
> > ---
> >   drivers/irqchip/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 1f23a6be7d88..bbb11cb8b0f7 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -298,7 +298,7 @@ config XTENSA_MX
> >     config XILINX_INTC
> >   	bool "Xilinx Interrupt Controller IP"
> > -	depends on OF
> > +	depends on OF_ADDRESS
> >   	select IRQ_DOMAIN
> >   	help
> >   	  Support for the Xilinx Interrupt Controller IP core.
>
> When above added feel free to add my
> Acked-by: Michal Simek <michal.simek@xxxxxxx>

No need to respin, I'll add the tag myself.

        M.
--
Jazz is not dead. It just smells funny...