Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema

From: Rob Herring
Date: Thu Jun 30 2022 - 11:28:14 EST


On Tue, Jun 28, 2022 at 08:09:39PM -0600, Rob Herring wrote:
> On Tue, 28 Jun 2022 20:21:39 +0200, Vincent Knecht wrote:
> > Convert leds-is31fl319x.txt to dtschema.
> > Set license to the one recommended by DT project.

Do you have permission to do so? The original .txt file is default GPL2
and owned by H. Nikolaus Schaller.

> >
> > Signed-off-by: Vincent Knecht <vincent.knecht@xxxxxxxxxx>
> > ---
> > .../bindings/leds/issi,is31fl319x.yaml | 113 ++++++++++++++++++
> > .../bindings/leds/leds-is31fl319x.txt | 61 ----------
> > 2 files changed, 113 insertions(+), 61 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml
> > delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const': '$ref'}
> hint: Standard unit suffix properties don't need a type $ref
> from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to match any schema with compatible: ['adi,ltc2983']

You can ignore this. The bot went amuck.

Rob