Re: [PATCH net-next] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

[Clément Léger]

Le Wed, 29 Jun 2022 11:13:04 +0200,
Clément Léger <clement.leger@xxxxxxxxxxx> a écrit :

> Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
> are connected to the GIC.
> 
> Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>
> ---
>  .../bindings/net/dsa/renesas,rzn1-a5psw.yaml  | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> index 103b1ef5af1b..51f274c16ed1 100644
> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> @@ -26,6 +26,22 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    items:
> +      - description: DLR interrupt
> +      - description: Switch interrupt
> +      - description: PRP interrupt
> +      - description: Integrated HUB module interrupt
> +      - description: RX Pattern interrupt
> +
> +  interrupts-names:
> +    items:
> +      - const: dlr
> +      - const: switch
> +      - const: prp
> +      - const: hub
> +      - const: ptrn
> +
>    power-domains:
>      maxItems: 1
>  
> @@ -76,6 +92,7 @@ examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
>      #include <dt-bindings/clock/r9a06g032-sysctrl.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>  
>      switch@44050000 {
>          compatible = "renesas,r9a06g032-a5psw", "renesas,rzn1-a5psw";
> @@ -83,6 +100,12 @@ examples:
>          clocks = <&sysctrl R9A06G032_HCLK_SWITCH>, <&sysctrl R9A06G032_CLK_SWITCH>;
>          clock-names = "hclk", "clk";
>          power-domains = <&sysctrl>;
> +        interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> +        interrupts-name = "dlr", "switch", "prp", "hub", "ptrn";

Wait, there is actually a typo both here and in the property
description, should be "interrupt-names". Was not catched by
dt_binding_check though but probably due to the fact additionnal
properties are allowed.

>  
>          dsa,member = <0 0>;
>  


-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com