Re: [PATCH] remoteproc: qcom: pas: Add decrypt shutdown support for modem

From: Bjorn Andersson
Date: Thu Jun 30 2022 - 15:29:35 EST


On Fri 20 May 02:28 CDT 2022, Sibi Sankar wrote:
> +static int adsp_decrypt_shutdown(struct qcom_adsp *adsp)

Forgot to write down one comment, how about naming this
adsp_shutdown_poll_decrypt() to make it slightly more clear from the
name what's going on here?

Thanks,
Bjorn

> +{
> + int retry_num = 50;
> + int ret = -EINVAL;
> +
> + while (retry_num && ret) {
> + msleep(ADSP_DECRYPT_SHUTDOWN_DELAY_MS);
> + ret = qcom_scm_pas_shutdown(adsp->pas_id);
> + retry_num--;
> + }
> +
> + return ret;
> +}
> +