Re: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information file

From: Al Viro
Date: Thu Jun 30 2022 - 19:02:06 EST


On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote:

> +static void
> +mshare_evict_inode(struct inode *inode)
> +{
> + clear_inode(inode);
> +}

Again, what for? And while we are at it, shouldn't you evict the
pages when inode gets freed and ->i_data along with it?
IOW, aren't you missing
truncate_inode_pages_final(&inode->i_data);
That, or just leave ->evict_inode NULL...